Crash in TweenLite on _tempKill lookup

[Alex Spiridonov]

Hello!

 

In our app after updating greensock up to v12 we met some strange crash occuring from time to time.

Here the rest of exception we caught:

ReferenceError: Error #1069: Property _tempKill not found on Boolean and 
there is no default value. at 
com.greensock::TweenLite/_kill()[F:\dev\cinderella\wc\client\lib\com\greensock\TweenLite.as:798] at 
com.greensock::TweenLite$/killTweensOf()[F:\dev\cinderella\wc\client\lib\com\greensock\TweenLite.as:1142]

We got to reproduce the crash and finally fixed the issue by next patch (TweenLite.as@798):

-     record = (vars != overwrittenProps && 
overwrittenProps != "all" && vars != propLookup && (vars == null 
|| vars._tempKill != true));

+     record = (vars != overwrittenProps && 
overwrittenProps != "all" && vars != propLookup && (vars == null 
|| !vars.hasOwnProperty("_tempKill") || vars._tempKill != true));

 

 

It would be great to get some comments or see this patch in next version of GreenSock

 

best regards,

Alex Spiridonov

[GreenSock]

Hmm...it sounds like you have some rogue code somewhere that's doing something like:

TweenLite.killTweensOf(object, true);

That second parameter is supposed to be an object, not a Boolean. 

[Alex Spiridonov]

Hmm...it sounds like you have some rogue code somewhere that's doing something like:

TweenLite.killTweensOf(object, true);

That second parameter is supposed to be an object, not a Boolean. 

Yes, exactly right - such code is remained from v11.

But it doesn't generate any compiler error or warning and so looks as legal. I think anyway it should be better if library does not crash app in this case.

 

best regards,

Alex