Jump to content
Search Community

ScrollTrigger - OnEnter - SetInterval (problem)

ilyasseisov test
Moderator Tag

Go to solution Solved by mvaneijgen,

Recommended Posts

Good day!

 

I'm trying to use simple setInterval() with onEnter() of ScrollTrigger.

The code works. The ScrollTrigger - triggers. But together they don't work.

 

Hers is the code:

Value animate  function:

const animateValue = (startVal, finishVal, durationVal) => {
//
let startValue = startVal;
let finishValue = finishVal;
let duration = durationVal;
let increment = Math.trunc(((finishValue - startValue) / duration) * 50);
let current = startValue;
 
let interval = setInterval(() => {
//
current += increment;
if (current >= finishValue) {
clearInterval(interval);
current = finishValue;
}
console.log(current);
//
}, 10);
};

ScrollTrigger

const odometersAll = gsap.utils.toArray('[data-odometer]');
//
//
odometersAll.forEach((odometer) => {
//
ScrollTrigger.create({
trigger: odometer,
start: '-240px 30%',
markers: true,
onEnter: () => {
//
animateValue(
parseInt(odometer.dataset.odometer),
parseInt(odometer.textContent),
3000
);
//
},
});
//
});

What is the issue?

 

Thanks in advance!

Link to comment
Share on other sites

Without a minimal demo, it's very difficult to troubleshoot; the issue could be caused by CSS, markup, a third party library, a 3rd party script, etc. Would you please provide a very simple CodePen or Stackblitz that illustrates the issue? 

 

Please don't include your whole project. Just some colored <div> elements and the GSAP code is best. See if you can recreate the issue with as few dependancies as possible. Start minimal and then incrementally add code bit by bit until it breaks. Usually people solve their own issues during this process! If not, at least we have a reduced test case which greatly increases your chances of getting a relevant answer.

 

See the Pen aYYOdN by GreenSock (@GreenSock) on CodePen

that loads all the plugins. Just click "fork" at the bottom right and make your minimal demo

 

Using a framework/library like React, Vue, Next, etc.? 

CodePen isn't always ideal for these tools, so here are some Stackblitz starter templates that you can fork and import the gsap-trial NPM package for using any of the bonus plugins: 

 

Please share the StackBlitz link directly to the file in question (where you've put the GSAP code) so we don't need to hunt through all the files. 

 

Once we see an isolated demo, we'll do our best to jump in and help with your GSAP-specific questions. 

Link to comment
Share on other sites

Without a minimal demo it is hard to help you debug, but I know setInterval is a function I personally rather not use it is just to inconsistent and you need to do a lot of clean up to have things not infinitely repeat or start to loop over each other. 

 

That said have you seen gsap.delayedCall() https://gsap.com/docs/v3/GSAP/gsap.delayedCall()/ does what setInterval should do, but no clean up and is completely insync with everting GSAP does. 

 

If you still need help please provide a minimal demo so that we can dive directly in to the code and help you debug. Hope it helps and happy tweening! 

Link to comment
Share on other sites

  • Solution

I don't have time to debug your function, but you're using GSAP anyways, so why not let GSAP handle it for you? 

 

I've add a tween to your onEnter which animates the innerText of the h3 to the number in the dataset. It has a delay of 3 seconds on the tween. I’ve placed some comments in your JS to better explain things, please be sure to read through them! Hope it helps and happy tweening! 

 

https://gsap.com/docs/v3/GSAP/CorePlugins/Snap/?_highlight=snap

 

See the Pen poYBREO?editors=1010 by mvaneijgen (@mvaneijgen) on CodePen

  • Like 2
Link to comment
Share on other sites

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
  • Recently Browsing   0 members

    • No registered users viewing this page.
×
×
  • Create New...