Timeline.seek typescript typings

[spassvogel]

According to the docs https://greensock.com/docs/v3/GSAP/Timeline/seek() the seek() method takes either a string or a number as its first argument. However, the typescript typings currently say:    seek(time: number, supressEvents?: boolean): this;

 

So the TS compiler throws a an error:

Argument of type 'string' is not assignable to parameter of type 'number'.

 

Using "gsap": "^3.2.6"

 

[spassvogel]

I would make a PR but it seems there are three outstanding PRs and they are all from last year and are about typings.. https://github.com/greensock/GSAP/pulls

 

are PRs about typings accepted?

[OSUblake]

5 hours ago, spassvogel said:

are PRs about typings accepted?

 

No. The main repo is private. If there's a problem with the typings, just raise an issue. And it looks like this has already been fixed in the next release.

 

In the meantime, you can ignore the error.

// @ts-ignore
tl.seek("")

 

Or augment the types in a d.ts file.

declare namespace gsap.core {
  interface Timeline {
    seek(time: number | string, supressEvents?: boolean): this;    
  }
}