Error in Dreamweaver

[Ava]

Hi,

 

I have used this script to animate a loop. The end animation look fine and everything seems to work.

But when i open the JS file with Adobe Dreameweaver I get many complaints (missing semicolon,
’text2’ is not defined, and missing ’used strict’ statement). Do I need to be worried?

 

Best,

Ava

 

window.onload = function () {
    var tl = new TimelineMax({repeat:-1});

    loop = 0;
    loopMax = 3;


     tl.to(text1, 1.2, {top:0,opacity:1,ease:Power4.easeOut})
    .to(text1, 1.2, {delay:.6,top:600,ease:Power4.easeIn})
    .to(text1, 0, {top:-600,ease:Power4.easeOut})

    .to(text2, 1.2, {top:0,opacity:1,ease:Power4.easeOut})

    .from(text3, 1, {top:0, opacity:0,scale:0,ease:Bounce.easeOut})
    .call(loopCheck)
    .to(text3, 0.5, {delay:1.2,opacity:0,scale:0,ease:Power4.easeOut})
    .to(text2, 1.2, {top:600,ease:Power4.easeIn})

tl.timeScale(1)

function loopCheck() {
  console.log("loopCheck")
     loop++;
     if (loop < loopMax) {
        console.log("play again")
        tl.play();
     } else{
       console.log("done")
       tl.pause();
     }

}
}
 

[joe_midi]

Hi Ava,

 

Welcome to the Greensock forums!

 

While your code would work, Dreamweaver is just advising you that there could potentially be problems. A lot of these you will learn as you progress through your learning of Javascript. 

 

Tools like http://jshint.com/ and http://eslint.org/ will help with writing better quality Javascript.

 

Below is an example of what would clear those errors, I've defined your variables, and hoisted the loopCheck function to before it gets called.

window.onload = function () {
    var tl = new TimelineMax({ repeat: -1 });
    var loop = 0;
    var loopMax = 3;

    var text1 = document.getElementById('text1');
    var text2 = document.getElementById('text2');
    var text3 = document.getElementById('text3');

    function loopCheck() {
      console.log('loopCheck')
      loop++;
      if (loop < loopMax) {
        console.log('play again')
        tl.play();
      } else{
        console.log('done')
        tl.pause();
      }
    }

    tl.to(text1, 1.2, {top:0,opacity:1,ease:Power4.easeOut})
      .to(text1, 1.2, {delay:.6,top:600,ease:Power4.easeIn})
      .to(text1, 0, {top:-600,ease:Power4.easeOut})
      .to(text2, 1.2, {top:0,opacity:1,ease:Power4.easeOut})
      .from(text3, 1, {top:0, opacity:0,scale:0,ease:Bounce.easeOut})
      .call(loopCheck)
      .to(text3, 0.5, {delay:1.2,opacity:0,scale:0,ease:Power4.easeOut})
      .to(text2, 1.2, {top:600,ease:Power4.easeIn});

    tl.timeScale(1);
}

[Ava]

Hi,

 

Thanks for your feedback. I really appreciate it a lot.

 

Best,

 

Ava

[WarenGonzaga]

Dreamweaver is using JsLint to check the potential errors within your javascript if your "TweenLite" or "TweenMax" syntax has errors you should put this lines to define it globally.

JavaScript

/* global TweenMax */
/* global TweenLite */

You can look here for more information!

http://www.jslint.com/help.html

[Ava]

Hi,

 

Thank you WarenGonzaga for your feedback.

This was really helpful.

 

Best,

Ava