Observer disable and enable not working as expected

[ihollarmide]

I am still able to scrolll the page when the step is 0. The onUp still also weirdly works when the step is 0. The behavior seems inconsistent

 

import { gsap } from "gsap";
import { useGSAP } from "@gsap/react";
import { Observer } from "gsap/Observer";
    

gsap.registerPlugin(useGSAP, Observer);  


function Animation() {
const step = useLandingStore(state => state.step);
const setStep = useLandingStore(state => state.setStep)

const onGoBack = () => {
    if (step === 0) return;
    const newStep = step - 1;

    setStep(newStep)
    if(newStep === 0) {
      if (entrySlideRef.current) {

        entrySlideRef.current.scrollIntoView({ behavior: "smooth" })
      } else {
        console.log("entrySlideRef not found")
      }
    }
  }

  const onGoForward = () => {
    if (step === 1) return;
    const newStep = step + 1;
    setStep(newStep)
  }

useGSAP(() => {

    if (!containerRef.current) return;
    const observer = Observer.create({
      target: containerRef.current,
      type: "wheel,touch,scroll",
       preventDefault: step === 0 ? false : true,
      tolerance: 10,
      onUp: onGoBack,
      onDown: onGoForward,
    });
    


    if (step > 0) {
      if (!observer.isEnabled) {
        console.log("I am disabled, enable observer")
        observer.enable();
      }
    } else {
      if (observer.isEnabled) {
        console.log("I am enabled, disable observer")
        observer.disable();
      }
    }

    return () => {
      observer.disable();
    }

  }, [step])

return <div></div>

}

 

[GSAP Helper]

Without a minimal demo, it's very difficult to troubleshoot; the issue could be caused by CSS, markup, a third party library, a 3rd party script, etc. Would you please provide a very simple CodePen or Stackblitz that illustrates the issue? 

 

Please don't include your whole project. Just some colored <div> elements and the GSAP code is best. See if you can recreate the issue with as few dependencies as possible. Start minimal and then incrementally add code bit by bit until it breaks. Usually people solve their own issues during this process! If not, at least we have a reduced test case which greatly increases your chances of getting a relevant answer.

 

See the Pen aYYOdN by GreenSock (@GreenSock) on CodePen.

that loads all the plugins. Just click "fork" at the bottom right and make your minimal demo: 

 

Using a framework/library like React, Vue, Next, etc.? 

CodePen isn't always ideal for these tools, so here are some Stackblitz starter templates that you can fork and import GSAP as shown in the Install Helper in our Learning Center : 

• React (please read this article!)
• Next
• Svelte
• Sveltekit
• Vue
• Nuxt

 

Please share the StackBlitz link directly to the file in question (where you've put the GSAP code) so we don't need to hunt through all the files. 

 

Once we see an isolated demo, we'll do our best to jump in and help with your GSAP-specific questions. ✅