Maybe some noob problem, trying to move a codepen from MaxTween to GSAP 3

[NovamIT]

Hi,

 

I found a very nice testimonial slider on codepen which uses an old version of GSAP (TweenMax 1.19) and I'm trying to convert it to GSAP3 with MotionPath instead of bezier. The original is found here:

See the Pen wvYBGPY by NovamIT (@NovamIT) on CodePen

 

The animations are working, but the Array shift isn't doing anything. In the orginal version a setTimout is being used to shift the testimonials array and restart the animation based on the timeout. I wanted to create a timeline with a repeat function and a repeatDelay. The array shift function i've set on the onRepeat callback property in the timeline. The delay and the repeat are working, but the callback not (It's firing, but not shifting visually).

 

What am I doing wrong?

 

See the Pen gOBbPZW by NovamIT (@NovamIT) on CodePen

[GreenSock]

Here's a simple port of the old one: 

See the Pen GRYgZaY?editors=0010 by GreenSock (@GreenSock) on CodePen

 

The onComplete isn't being called when you expect because you're not giving it a function - you're invoking the function immediately and then assigning the result to the onComplete.

 

// BAD
onRepeat: sortArray(cards)

// GOOD
onRepeat: () => sortArray(cards)

// ALSO GOOD
onRepeat: function() { sortArray(cards) }